Skip to content

Implement SumTranform #1021

Merged
merged 6 commits into from
Nov 30, 2022
Merged

Implement SumTranform #1021

merged 6 commits into from
Nov 30, 2022

Conversation

brsnw250
Copy link
Collaborator

@brsnw250 brsnw250 commented Nov 29, 2022

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Look at #1013

Closing issues

Closes #1013

@github-actions
Copy link

github-actions bot commented Nov 29, 2022

@github-actions github-actions bot temporarily deployed to pull request November 29, 2022 09:40 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2022

Codecov Report

Merging #1021 (a32c680) into master (cfbfb01) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1021      +/-   ##
==========================================
- Coverage   86.11%   86.11%   -0.01%     
==========================================
  Files         162      162              
  Lines        8613     8627      +14     
==========================================
+ Hits         7417     7429      +12     
- Misses       1196     1198       +2     
Impacted Files Coverage Δ
etna/transforms/__init__.py 100.00% <100.00%> (ø)
etna/transforms/math/__init__.py 100.00% <100.00%> (ø)
etna/transforms/math/statistics.py 99.39% <100.00%> (+0.04%) ⬆️
etna/auto/runner/utils.py 50.00% <0.00%> (-50.00%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot temporarily deployed to pull request November 29, 2022 10:26 Inactive
Copy link
Collaborator

@alex-hse-repository alex-hse-repository left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Add one test case and update the Changelog

@github-actions github-actions bot temporarily deployed to pull request November 30, 2022 09:13 Inactive
@alex-hse-repository alex-hse-repository merged commit 4dd3d7f into master Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement SumTranform
3 participants