Add SaveEnsembleMixin
#1046
Merged
Add SaveEnsembleMixin
#1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## inference-v2 #1046 +/- ##
===============================================
Coverage ? 86.15%
===============================================
Files ? 164
Lines ? 8849
Branches ? 0
===============================================
Hits ? 7624
Misses ? 1225
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
🚀 Deployed on https://deploy-preview-1046--etna-docs.netlify.app |
Closed
martins0n
reviewed
Dec 20, 2022
etna/ensembles/mixins.py
Outdated
| # save transforms separately | ||
| pipelines_dir = temp_dir / "pipelines" | ||
| pipelines_dir.mkdir() | ||
| num_digits = len(str(len(pipelines) - 1)) |
There was a problem hiding this comment.
💣
What do you want to do?
We always can use fix len - for example 8 symbols - it will be enough
There was a problem hiding this comment.
Ok, I will also change that for transforms (we have the same logic where).
martins0n
approved these changes
Dec 22, 2022
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Look #1043.
Closing issues
Closed #1043.