Skip to content

add RMSE metric & rmse functional metric #1051

Merged
merged 3 commits into from
Dec 26, 2022

Conversation

smetam
Copy link
Contributor

@smetam smetam commented Dec 22, 2022

Before submitting (must do checklist)

  • [ x] Did you read the contribution guide?
  • [ x] Did you update the docs? We use Numpy format for all the methods and classes.
  • [ x] Did you write any new necessary tests?
  • [ x] Did you update the CHANGELOG?

Proposed Changes

Closing issues

closes #1031

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2022

Codecov Report

Merging #1051 (61ed089) into master (92e1ba4) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1051      +/-   ##
==========================================
+ Coverage   86.13%   86.25%   +0.11%     
==========================================
  Files         163      163              
  Lines        8629     8641      +12     
==========================================
+ Hits         7433     7453      +20     
+ Misses       1196     1188       -8     
Impacted Files Coverage Δ
etna/metrics/__init__.py 100.00% <100.00%> (ø)
etna/metrics/functional_metrics.py 86.95% <100.00%> (+1.95%) ⬆️
etna/metrics/metrics.py 100.00% <100.00%> (ø)
etna/auto/runner/utils.py 50.00% <0.00%> (-50.00%) ⬇️
etna/libs/tsfresh/significance_tests.py 46.37% <0.00%> (+14.49%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

CHANGELOG.md Outdated
@@ -8,7 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased
### Added
-
- `RMSE` metric & `rmse` functional metric
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May you also add a ling to the current PR in the format "([#<pr number>](link))". See the raw view of CHANGELOG.md file for the examples

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

etna/metrics/metrics.py Show resolved Hide resolved
Copy link
Collaborator

@alex-hse-repository alex-hse-repository left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!)
Feel free to choose more complicated issues, we will be happy to help if you meet any difficulties.
If you can't find interesting issues you can write us in the telegram, we will try to suggest you sth.

@alex-hse-repository alex-hse-repository merged commit f46b363 into tinkoff-ai:master Dec 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RMSE metric
3 participants