Fixes from inference track #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-1096--etna-docs.netlify.app |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## etna_v2 #1096 +/- ##
============================================
+ Coverage 69.04% 86.74% +17.70%
============================================
Files 177 166 -11
Lines 9661 9390 -271
============================================
+ Hits 6670 8145 +1475
+ Misses 2991 1245 -1746
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alex-hse-repository
suggested changes
Feb 14, 2023
tests/test_transforms/test_decomposition/test_change_points_based/test_level.py
Show resolved
Hide resolved
alex-hse-repository
suggested changes
Feb 14, 2023
| """ | ||
| fit_ts = self._fit_ts | ||
|
|
||
| try: |
There was a problem hiding this comment.
Why you did it via try/except?
There was a problem hiding this comment.
What is your alternative? I wanted to make action inside finally block even if there is some exception. That is why I did it like this.
| def check_no_fit_ts(path): | ||
| assert not hasattr(pipeline, "_fit_ts") | ||
|
|
||
| mocked_load.side_effect = check_no_fit_ts |
alex-hse-repository
pushed a commit
that referenced
this pull request
Feb 22, 2023
alex-hse-repository
pushed a commit
that referenced
this pull request
Mar 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Look #1093.
HierarchicalPipelineok.Closing issues
Closes #1093.