Fix WindowStatisticsTransform
#1128
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
🚀 Deployed on https://deploy-preview-1128--etna-docs.netlify.app |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## etna_v2 #1128 +/- ##
============================================
+ Coverage 51.37% 86.64% +35.27%
============================================
Files 166 166
Lines 9351 9360 +9
============================================
+ Hits 4804 8110 +3306
+ Misses 4547 1250 -3297
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Why is branch named |
| transform.fit(ts_with_exog_galeshapley.to_pandas()) | ||
| df = transform.transform(ts_with_exog_galeshapley.to_pandas()) | ||
| transform.fit(ts_with_exog_galeshapley) | ||
| ts = transform.transform(ts_with_exog_galeshapley) |
There was a problem hiding this comment.
How did this test pass before?
There was a problem hiding this comment.
It is the artefact of rebase, is you see the PR with etna_v2 it fails there
No, it is typo |
| @@ -81,10 +80,10 @@ def _get_column_name(self) -> str: | |||
|
|
|||
| def get_regressors_info(self) -> List[str]: | |||
| """Return the list with regressors created by the transform.""" | |||
| if self.in_column_regressor is None: | |||
| raise ValueError("Fit the transform to get the correct regressors info!") | |||
| if self.inplace: | |||
There was a problem hiding this comment.
Do we really need to check inplace after self.in_column_regressor is None?
There was a problem hiding this comment.
Yes we do because in case of inplace=True we return the empty list
| @@ -359,10 +358,10 @@ def _get_column_name(self) -> str: | |||
|
|
|||
| def get_regressors_info(self) -> List[str]: | |||
| """Return the list with regressors created by the transform.""" | |||
| if self.in_column_regressor is None: | |||
| raise ValueError("Fit the transform to get the correct regressors info!") | |||
| if self.inplace: | |||
| @@ -164,10 +164,10 @@ def _get_out_column(self, out_column: Optional[str]) -> str: | |||
|
|
|||
| def get_regressors_info(self) -> List[str]: | |||
| """Return the list with regressors created by the transform.""" | |||
| if self.in_column_regressor is None: | |||
| raise ValueError("Fit the transform to get the correct regressors info!") | |||
Before submitting (must do checklist)
Proposed Changes
Closing issues
closes #1008