Skip to content

Remove version python-3.7 from pyproject.toml, update lock #1183

Merged
merged 14 commits into from
Mar 29, 2023

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Mar 27, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

  • Remove version python-3.7 from pyproject.toml
  • Update poetry.lock
  • Add poetry.toml into gitignore

Closing issues

@Mr-Geekman Mr-Geekman self-assigned this Mar 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2023

Codecov Report

Merging #1183 (b4c8e11) into master (6a8e478) will decrease coverage by 18.53%.
The diff coverage is 93.75%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           master    #1183       +/-   ##
===========================================
- Coverage   87.65%   69.13%   -18.53%     
===========================================
  Files         177      177               
  Lines       10380    10380               
===========================================
- Hits         9099     7176     -1923     
- Misses       1281     3204     +1923     
Impacted Files Coverage Δ
etna/analysis/eda_utils.py 19.93% <0.00%> (-41.14%) ⬇️
etna/analysis/outliers/median_outliers.py 95.83% <100.00%> (ø)
etna/clustering/distances/euclidean_distance.py 73.68% <100.00%> (-21.06%) ⬇️
etna/datasets/tsdataset.py 73.73% <100.00%> (-18.98%) ⬇️
...mental/classification/feature_extraction/weasel.py 97.67% <100.00%> (ø)
etna/transforms/encoders/mean_segment_encoder.py 100.00% <100.00%> (ø)
etna/transforms/math/differencing.py 97.76% <100.00%> (ø)

... and 66 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Mar 27, 2023

@github-actions github-actions bot temporarily deployed to pull request March 27, 2023 07:44 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 27, 2023 10:05 Inactive
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot temporarily deployed to pull request March 27, 2023 10:20 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 27, 2023 13:24 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 27, 2023 14:38 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 27, 2023 17:12 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 27, 2023 17:30 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 27, 2023 20:10 Inactive
@@ -59,10 +59,12 @@ jobs:
path: .venv
key: venv-${{ runner.os }}-${{ matrix.python-version }}-${{ hashFiles('**/poetry.lock') }}

# TODO: remove pip install after optuna fix
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I write that user should also install the correct version of sqlalchemy? Should't we inform him somehow about it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If he has incorrect version he will face some errors working with databases in optuna (it is optuna's problem, not ours).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it be obvious that the problem is in sqlalchimy?

etna/analysis/outliers/median_outliers.py Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request March 29, 2023 07:23 Inactive
@Mr-Geekman Mr-Geekman merged commit aa1f9c1 into master Mar 29, 2023
@Mr-Geekman Mr-Geekman deleted the update-python branch March 29, 2023 08:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants