Skip to content

S3 and file logger -- change experiment folder name timestamp rounding #1264

Merged
merged 1 commit into from
May 18, 2023

Conversation

malodetz
Copy link
Collaborator

@malodetz malodetz commented May 18, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

See #947

Closing issues

Closes #947

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2023

Codecov Report

Merging #1264 (b79d60a) into master (d224aec) will increase coverage by 0.35%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1264      +/-   ##
==========================================
+ Coverage   87.63%   87.98%   +0.35%     
==========================================
  Files         175      186      +11     
  Lines       10438    10751     +313     
==========================================
+ Hits         9147     9459     +312     
- Misses       1291     1292       +1     
Impacted Files Coverage Δ
etna/loggers/file_logger.py 73.21% <100.00%> (ø)

... and 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

@github-actions github-actions bot temporarily deployed to pull request May 18, 2023 08:11 Inactive
Copy link
Collaborator

@alex-hse-repository alex-hse-repository left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alex-hse-repository alex-hse-repository enabled auto-merge (squash) May 18, 2023 08:43
@alex-hse-repository alex-hse-repository merged commit fb5f6d4 into master May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 and file logger -- change experiment folder name timestamp rounding
3 participants