Skip to content

Update depenencies for better colab experience #1268

Merged
merged 11 commits into from
May 25, 2023
Merged

Update depenencies for better colab experience #1268

merged 11 commits into from
May 25, 2023

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented May 23, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

  • Update holidays library dependency
  • Update scipy library dependency
  • Update torch library dependency
    • There was a problem with saving MLP and RNN with dill, so cloudpickle is used
    • It still doesn't work on torch-2.0, saving doesn't for nor for cloudpickle, nor for dill

Closing issues

Closes #1266.

@Mr-Geekman Mr-Geekman self-assigned this May 23, 2023
@github-actions
Copy link

github-actions bot commented May 23, 2023

@Mr-Geekman
Copy link
Contributor Author

Mr-Geekman commented May 23, 2023

We should probably revert changes related to torch and make them later.

We should probably rewrite saving later using something more native, for example state_dict. It will help us to support torch-2.0.

@github-actions github-actions bot temporarily deployed to pull request May 23, 2023 16:02 Inactive
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2023

Codecov Report

Merging #1268 (3def146) into master (0e6d87a) will increase coverage by 0.37%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1268      +/-   ##
==========================================
+ Coverage   87.67%   88.04%   +0.37%     
==========================================
  Files         186      186              
  Lines       10778    10778              
==========================================
+ Hits         9450     9490      +40     
+ Misses       1328     1288      -40     
Impacted Files Coverage Δ
etna/core/mixins.py 95.30% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot temporarily deployed to pull request May 24, 2023 07:18 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 24, 2023 11:53 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 24, 2023 12:04 Inactive
@Mr-Geekman Mr-Geekman requested a review from martins0n May 25, 2023 07:48
martins0n
martins0n previously approved these changes May 25, 2023
@@ -13,6 +12,7 @@
from typing import Tuple
from typing import cast

import dill
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, this is a breaking change potentially

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially, yes, but current tests are passing, so I hope it will be fine.

I added this only because with new version of holidays library saving/loading doesn't work for HolidaysTransform.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example, we can try to change this only for HolidayTransform, what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly, if I run tests locally, tests for HolidayTransform are working fine. They fail only on github.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be you have some ideas about the error: ci.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reproduced this bug on my personal linux machine. Investigating.

@martins0n
Copy link
Contributor

martins0n commented May 25, 2023

plus Changelog

@github-actions github-actions bot temporarily deployed to pull request May 25, 2023 12:28 Inactive
@Mr-Geekman Mr-Geekman merged commit ddf0640 into master May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colab python 3.10 compatibility check
3 participants