-
Notifications
You must be signed in to change notification settings - Fork 80
Update depenencies for better colab experience #1268
Conversation
🚀 Deployed on https://deploy-preview-1268--etna-docs.netlify.app |
We should probably revert changes related to We should probably rewrite saving later using something more native, for example |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1268 +/- ##
==========================================
+ Coverage 87.67% 88.04% +0.37%
==========================================
Files 186 186
Lines 10778 10778
==========================================
+ Hits 9450 9490 +40
+ Misses 1328 1288 -40
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -13,6 +12,7 @@ | |||
from typing import Tuple | |||
from typing import cast | |||
|
|||
import dill |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, this is a breaking change potentially
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potentially, yes, but current tests are passing, so I hope it will be fine.
I added this only because with new version of holidays
library saving/loading doesn't work for HolidaysTransform
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example, we can try to change this only for HolidayTransform
, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interestingly, if I run tests locally, tests for HolidayTransform
are working fine. They fail only on github.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be you have some ideas about the error: ci.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reproduced this bug on my personal linux machine. Investigating.
plus Changelog |
Before submitting (must do checklist)
Proposed Changes
dill
, socloudpickle
is usedtorch-2.0
, saving doesn't for nor forcloudpickle
, nor fordill
Closing issues
Closes #1266.