Skip to content

Fix classification notebook to download FordA dataset without error #1298

Merged
merged 7 commits into from
Jun 28, 2023

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Jun 27, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Rewrite passage for downloadig FordA dataset.

Closing issues

@Mr-Geekman Mr-Geekman added the bug Something isn't working label Jun 27, 2023
@Mr-Geekman Mr-Geekman self-assigned this Jun 27, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

github-actions bot commented Jun 27, 2023

@github-actions github-actions bot temporarily deployed to pull request June 27, 2023 13:21 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2023

Codecov Report

Merging #1298 (7052481) into master (72c8aea) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #1298   +/-   ##
=======================================
  Coverage   88.77%   88.77%           
=======================================
  Files         193      193           
  Lines       11751    11751           
=======================================
  Hits        10432    10432           
  Misses       1319     1319           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Mr-Geekman Mr-Geekman requested a review from brsnw250 June 28, 2023 07:36
examples/classification.ipynb Show resolved Hide resolved
examples/classification.ipynb Show resolved Hide resolved
examples/classification.ipynb Show resolved Hide resolved
Copy link
Collaborator

@brsnw250 brsnw250 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small fixes

@github-actions github-actions bot temporarily deployed to pull request June 28, 2023 11:42 Inactive
brsnw250
brsnw250 previously approved these changes Jun 28, 2023
@github-actions github-actions bot temporarily deployed to pull request June 28, 2023 11:59 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 28, 2023 12:53 Inactive
@Mr-Geekman Mr-Geekman enabled auto-merge (squash) June 28, 2023 14:43
@Mr-Geekman Mr-Geekman disabled auto-merge June 28, 2023 14:43
@Mr-Geekman Mr-Geekman merged commit e7264c1 into master Jun 28, 2023
12 checks passed
@Mr-Geekman Mr-Geekman deleted the fix-classification-notebook branch June 28, 2023 14:52
@Mr-Geekman Mr-Geekman restored the fix-classification-notebook branch June 28, 2023 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants