Rework library introduction #1343
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## docs-prototype #1343 +/- ##
=================================================
Coverage ? 88.66%
=================================================
Files ? 193
Lines ? 12328
Branches ? 0
=================================================
Hits ? 10931
Misses ? 1397
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
🚀 Deployed on https://deploy-preview-1343--etna-docs.netlify.app |
|
View / edit / reply to this conversation on ReviewNB alex-hse-repository commented on 2023-08-04T05:52:15Z Looks cool! |
|
View / edit / reply to this conversation on ReviewNB alex-hse-repository commented on 2023-08-04T05:52:16Z Let's place it in the beginning Mr-Geekman commented on 2023-08-04T06:42:36Z If we place it in the beginnig, we will lose the span: "Oups. Let's fix that by looking at the table of offsets in pandas" |
|
View / edit / reply to this conversation on ReviewNB alex-hse-repository commented on 2023-08-04T05:52:17Z Let's skip it |
|
View / edit / reply to this conversation on ReviewNB alex-hse-repository commented on 2023-08-04T05:52:18Z Why do we actually have warning as we set to ignore them in the beginning? Mr-Geekman commented on 2023-08-04T07:54:32Z Good point, I'll try to rerun it taking this into account |
|
View / edit / reply to this conversation on ReviewNB alex-hse-repository commented on 2023-08-04T05:52:19Z Do we want to add some info about how transforms works? For example that the work inplace? Mr-Geekman commented on 2023-08-04T07:55:29Z Isn't explanation below enough? |
|
View / edit / reply to this conversation on ReviewNB alex-hse-repository commented on 2023-08-04T05:52:20Z Line #2. forecast_ts.to_pandas() Why not just |
|
View / edit / reply to this conversation on ReviewNB alex-hse-repository commented on 2023-08-04T05:52:21Z We can end up saying that Pipeline do all this stuff inside and may be add the pseudo cod of it(optionally) |
| @@ -0,0 +1,230 @@ | |||
| { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
I don't really know how to do it properly. Because we could have multiple verision of the library in documentation and we should select here only one link to one particular version.
I tried to use this: https://myst-parser.readthedocs.io/en/latest/syntax/cross-referencing.html#reference-roles , but it doesn't work with notebooks converted by nbsphinx. Probably, MyST-nb could work with this, but it requires changing the current extension for compiling notebooks.
I've found that: https://docs.readthedocs.io/en/stable/guides/jupyter.html
There was a problem hiding this comment.
Not sure it is critical
|
Problems with rendering pictures in the notebooks |
|
Forget to add "Mechanics of forecasting" notebook |
|
If we place it in the beginnig, we will lose the span: "Oups. Let's fix that by looking at the table of offsets in pandas" View entire conversation on ReviewNB |
|
Good point, I'll try to rerun it taking this into account View entire conversation on ReviewNB |
|
Isn't explanation below enough? View entire conversation on ReviewNB |
|
Issues with rendering: |
Before submitting (must do checklist)
Proposed Changes
Look #1334.
Closing issues
Closes #1334.