Optuna and sweeps examples #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #338 +/- ##
=======================================
Coverage 85.43% 85.43%
=======================================
Files 148 148
Lines 7962 7962
=======================================
Hits 6802 6802
Misses 1160 1160 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
🚀 Deployed on https://deploy-preview-338--etna-docs.netlify.app |
martins0n
changed the title
alex-hse-repository
requested review from
iKintosh and
alex-hse-repository
and removed request for
iKintosh
alex-hse-repository
suggested changes
Oct 6, 2022
| pipeline: Pipeline = hydra_slayer.get_from_params(**pipeline) | ||
| backtest_configs = hydra_slayer.get_from_params(**backtest) | ||
|
|
||
| init_logger(pipeline.to_dict()) |
There was a problem hiding this comment.
This might work incorrectly sometimes, may be use config["pipeline"]?
There was a problem hiding this comment.
I think, it's better to use canonical way and to fix corner cases of to_dict.
Co-authored-by: alex-hse-repository <55380696+alex-hse-repository@users.noreply.github.com>
alex-hse-repository
approved these changes
Oct 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)
Type of Change
Proposed Changes
Related Issue
Closing issues
closes #288