Hotfix/cli bug #758
Merged
Hotfix/cli bug #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-758--etna-docs.netlify.app |
Codecov Report
@@ Coverage Diff @@
## master #758 +/- ##
===========================================
- Coverage 83.50% 50.72% -32.78%
===========================================
Files 122 122
Lines 6734 6746 +12
===========================================
- Hits 5623 3422 -2201
- Misses 1111 3324 +2213
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
| @@ -19,6 +23,12 @@ def backtest( | |||
| freq: str = typer.Argument(..., help="frequency of timestamp in files in pandas format"), | |||
| output_path: Path = typer.Argument(..., help="where to save forecast"), | |||
| exog_path: Optional[Path] = typer.Argument(default=None, help="path to csv with exog data"), | |||
| known_future: Optional[List[str]] = typer.Argument( | |||
| None, | |||
There was a problem hiding this comment.
why not default="all"?
There was a problem hiding this comment.
Because "all" is not List. And Typer does not support Union. So I can only configure it like this "all" if not known_future else known_future
There was a problem hiding this comment.
Why not?
It's normal workaround I guess
julia-shenshina
approved these changes
Jun 17, 2022
julia-shenshina
suggested changes
Jun 17, 2022
julia-shenshina
approved these changes
Jun 21, 2022
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)
Type of Change
Proposed Changes
Related Issue
Closing issues