Skip to content

[WIP] Binseg refactoring #998

Merged
merged 17 commits into from
Dec 26, 2022
Merged

[WIP] Binseg refactoring #998

merged 17 commits into from
Dec 26, 2022

Conversation

julia-shenshina
Copy link
Contributor

@julia-shenshina julia-shenshina commented Oct 26, 2022 •
edited
Loading

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Closing issues

@julia-shenshina julia-shenshina marked this pull request as draft October 26, 2022 15:01
@github-actions
Copy link

github-actions bot commented Oct 26, 2022 •
edited
Loading

🚀 Deployed on https://deploy-preview-998--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request October 26, 2022 15:05 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (tsdataset_2@45cc3b5). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             tsdataset_2     #998   +/-   ##
==============================================
  Coverage               ?   85.51%           
==============================================
  Files                  ?      156           
  Lines                  ?     8296           
  Branches               ?        0           
==============================================
  Hits                   ?     7094           
  Misses                 ?     1202           
  Partials               ?        0

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot temporarily deployed to pull request November 2, 2022 13:39 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 2, 2022 13:52 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 2, 2022 15:43 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 3, 2022 18:09 Inactive
@alex-hse-repository
Copy link
Collaborator

  1. Add tests for SklearnBasedPerIntervalModel
  2. Add tests for _apply_transformation, _apply_inverse_transformation, _get_features, _get_targets for the places where they are overriden

alex-hse-repository
alex-hse-repository suggested changes Nov 29, 2022
View reviewed changes
etna/transforms/decomposition/change_points_based/per_interval_models/constant.py Outdated Show resolved Hide resolved
etna/transforms/decomposition/change_points_based/per_interval_models/constant.py Show resolved Hide resolved
etna/transforms/decomposition/change_points_based/per_interval_models/sklearn_based.py Outdated Show resolved Hide resolved
etna/transforms/decomposition/change_points_based/per_interval_models/sklearn_based.py Show resolved Hide resolved
etna/transforms/decomposition/change_points_based/per_interval_models/statistics_based.py Outdated Show resolved Hide resolved
...est_decomposition/test_change_points_based/test_per_interval_models/test_statistics_based.py Outdated Show resolved Hide resolved
..._decomposition/test_change_points_based/test_change_points_models/test_base_change_points.py Outdated Show resolved Hide resolved
tests/test_transforms/test_decomposition/test_transform_quantiles.py Show resolved Hide resolved
tests/test_core/test_to_dict.py Outdated Show resolved Hide resolved
tests/test_core/test_to_dict.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request December 6, 2022 14:58 Inactive
alex-hse-repository
alex-hse-repository suggested changes Dec 15, 2022
View reviewed changes
Copy link
Collaborator

@alex-hse-repository alex-hse-repository left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. There are unresolved threads
  2. Add tests for _apply_transformation, _apply_inverse_transformation, _get_features, _get_targets for ChangePointsTrendTransform , TrendTransform , ChangePointsSegmentationTransform (for overriden cases)

...position/test_change_points_based/test_change_points_models/test_base_change_points_model.py Show resolved Hide resolved
tests/test_core/test_to_dict.py Outdated Show resolved Hide resolved
...s/test_decomposition/test_change_points_based/test_per_interval_models/test_sklearn_based.py Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request December 21, 2022 06:58 Inactive
@julia-shenshina
Copy link
Contributor Author

  1. Add tests for _apply_transformation, _apply_inverse_transformation, _get_features, _get_targets for ChangePointsTrendTransform , TrendTransform , ChangePointsSegmentationTransform (for overriden cases)

you wanna check that df[column] = value writes value to df[column]? we already test it in test_transform-like tests + in tests for quantiles
about _get_features and _get_targets -- there are tests for them for transforms that reimplements these methods

@github-actions github-actions bot temporarily deployed to pull request December 21, 2022 07:58 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 21, 2022 08:08 Inactive
@julia-shenshina julia-shenshina marked this pull request as ready for review December 21, 2022 08:19
@github-actions github-actions bot temporarily deployed to pull request December 21, 2022 12:58 Inactive
alex-hse-repository
alex-hse-repository approved these changes Dec 26, 2022
View reviewed changes
etna/pipeline/assembling_pipelines.py
@@ -51,14 +51,14 @@ def assemble_pipelines(
--------
>>> from etna.pipeline import assemble_pipelines
>>> from etna.models import LinearPerSegmentModel, NaiveModel
>>> from etna.transforms import TrendTransform, AddConstTransform, LagTransform
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was wrong with TrendTransform here?

@alex-hse-repository alex-hse-repository merged commit 3e78846 into tsdataset_2 Dec 26, 2022
alex-hse-repository pushed a commit that referenced this pull request Feb 2, 2023
@julia-shenshina @alex-hse-repository
[WIP] Binseg refactoring (#998)
9134005
alex-hse-repository pushed a commit that referenced this pull request Feb 22, 2023
@julia-shenshina @alex-hse-repository
[WIP] Binseg refactoring (#998)
304d1da
alex-hse-repository pushed a commit that referenced this pull request Mar 2, 2023
@julia-shenshina @alex-hse-repository
[WIP] Binseg refactoring (#998)
aaac93b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alex-hse-repository alex-hse-repository alex-hse-repository approved these changes

Assignees

@julia-shenshina julia-shenshina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julia-shenshina @codecov-commenter @alex-hse-repository