This repository has been archived by the owner on Jun 15, 2023. It is now read-only.
Make EDID conform with edid-decode checks #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mtlynch - I've tested this EDID and found no issues so far. I added Is there anything else that to do before a review? |
|
You mentioned having to work around AW EDID Editor bugs. Can we document those in the comment above the EDID? |
Automated comment from CodeApprove ➜⏳ @mtlynch please review this Pull Request |
mtlynch
approved these changes
May 12, 2023
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
✔️ Approved
LGTM, thanks!
I'll break protocol and merge on your behalf since I believe you're now on vacation.
👀 @db39 it's your turn please take a look
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our previous EDIDs failed to conform with
edid-decode's--checkflag.This updated EDID has a number of modifications to make it conform with the
tests - fixing the warnings and failed attributes.
Warnings fixed:
IT Video formats are now underscanned by default.
There are no longer multiple native progressive timings defined.
Failures fixed:
Detailed Timing Descriptor 1 no longer lists an image size.
Detailed Timing Descriptor 2 no longer lists an image size.
Display Range Limits now sets the correct bytes: Byte 11 is 0x00 and
Bytes 12-17 are now 0x20.
There are no longer more Native Detailed Timing Descriptors than
Detailed Timing Descriptors.
Removed duplicate video data definition (VIC 60)
Adjusted monitor ranges to 24-90 Hz (Vertical Freq) and 18-80 kHz
(Horizontal Freq)