Optionally install uStreamer from Debian package #110
Conversation
jdeanwallace
changed the title
This reverts commit 179fe04.
Automated comment from CodeApprove ➜⏳ @jotaen4tinypilot please review this Pull Request |
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
In: Discussion
I didn’t get around to reviewing this yet, but I installed the bundle from the scratch PR while testing tiny-pilot/ustreamer-debian#6. I noticed that it still installs Janus via Ansible during the bundle installation:
TASK [ansible-role-ustreamer : enable Janus apt suite] ******************************************
changed: [localhost]
TASK [ansible-role-ustreamer : install Janus package and C header files] ************************
changed: [localhost]
TASK [ansible-role-ustreamer : patch Janus plugin.h file to successfully include refcount.h file] ***
changed: [localhost]
Wouldn’t that be obsolete when we install the uStreamer Debian package? (I might be missing something here, though?)
👀 @jdeanwallace it's your turn please take a look
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
In: Discussion
Oh no, the uStreamer Debian package just includes the uStreamer Janus plugin and not Janus itself (although Janus is indicated as a dependency). We still need to install Janus alongside uStreamer for WebRTC to work.
👀 @jotaen4tinypilot it's your turn please take a look
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
✔️ Approved
👍
I’ve tested on device via the scratch PR.
In: Discussion
Ah right, thanks – I forgot that Janus and the Janus plugin are two separate things!
👀 @jdeanwallace it's your turn please take a look
Related #100
This PR only builds uStreamer from source if a uStreamer Debian package is not provided. This will allow TinyPilot to specify a uStreamer Debian package and avoid building uStreamer from source on every install/update.
I've tested these changes in CI via 179fe04.
I've also tested these changes on device via a scratch TinyPilot Pro PR.