Skip to content
This repository has been archived by the owner on Jun 15, 2023. It is now read-only.

Fix molecule idempotence test. #79

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Fix molecule idempotence test. #79

merged 1 commit into from
Dec 5, 2022

Conversation

jdeanwallace
Copy link
Contributor

@jdeanwallace jdeanwallace commented Dec 2, 2022 •
edited
Loading

This is needed to fix the ansible-role-tinypilot build in tiny-pilot/ansible-role-tinypilot#240

I'm not too sure why the idempotence molecule test in this repo didn't pick up this bug 🤔
Review on CodeApprove

mtlynch
mtlynch approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@mtlynch mtlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtlynch
Copy link
Contributor

mtlynch commented Dec 2, 2022

I'm not too sure why the idempotence molecule test in this repo didn't pick up this bug 🤔

It's because we're not exercising the Janus steps in this repo since we run molecule with h264 in its default disabled setting.

TASK [ansible-role-ustreamer : install Janus] **********************************
skipping: [debian10]
skipping: [debian11]

@jdeanwallace jdeanwallace merged commit a067105 into master Dec 5, 2022
@jdeanwallace jdeanwallace deleted the idempotence branch December 5, 2022 12:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtlynch mtlynch mtlynch approved these changes

Assignees
No one assigned
Labels
codeapprove
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdeanwallace @mtlynch