Build Debian package using debhelper #1200
Conversation
Currently, this doesn't buy us much, but it gets us on the path where we can use dh_installsystemd, which will make it easier to install systemd services instead of rolling our own method outside of the Debian package.
This reverts commit 4675358.
Automated comment from CodeApprove ➜⏳ @jdeanwallace please review this Pull Request |
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
In: debian-pkg/debian/rules:
> Line 14
dh_install
I managed to build the Debian package without this hack. I've created a POC PR here: #1203
The missing information was that the source files need to be in the build directory (i.e., /releases/${PKG_ID}) and the files we want in the filesystem of the package should be listed in debian/tinypilot.install. Here's a vague explanation.
I also diffed your package contents to mine and they are the same.
In: debian-pkg/Dockerfile:
> Line 60
Architecture: all
Can we use ${PKG_ARCH} here?
In: debian-pkg/Dockerfile:
> Line 63
Description: "Simple, easy-to-use KVM over IP"
The description value is surrounded by quotes. Is that intentional?
👀 @mtlynch it's your turn please take a look
* Build Debian package. * Use debhelper install file. * Fix dir copy. * Fix file copy. * Move source to base dir. * Fix debian copy. * Only copy specific files. * Try different copyright notice. * Try different copyright notice. * Ignore lintian copyright check.
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
In: debian-pkg/debian/compat:
> Line 1
11
Small note - I realized that this refers to the version of debhelper not the version of Debian (like I previously though), so I changed it to 11 since the package declares a Build-Depends on debhelper >= 11.
In: debian-pkg/debian/rules:
Oh, nice! Thanks. That's way cleaner. I've merged your PR into mine.
In: debian-pkg/Dockerfile:
Oh right we just fixed that and I'm messing it up again.
In: debian-pkg/Dockerfile:
Oh, no, fixed.
👀 @jdeanwallace it's your turn please take a look
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
✔️ Approved
Thanks for figuring out how to use debhelper 🙌
👀 @mtlynch it's your turn please take a look
Currently, this doesn't buy us much, but it gets us on the path where we can use dh_installsystemd, which will make it easier to install systemd services instead of doing it manually within maintainer scripts (postinst, presinst).
One of the confusing behaviors of debhelper is how it sees the filesystem root. Without debhelper, all the files outside of the
debianmeta-directory in the folder/releases/${PKG_ID}would end up in the filesystem of the package (e.g., a file at path/releases/${PKG_ID}/opt/tinypilot/hello.txtwould tell the Debian package to install that file to/opt/tinypilot/hello.txtat install time).With debhelper, the files need to be in
/releases/${PKG_ID}/debian/tinypilotat dh_install time, but if we try placing them there when we calldpkg-buildpackage, debhelper can see every path except the folder calledtinypilot. As a workaround, we place the package files under/releases/${PKG_ID}/filerootand then rename the path to/releases/${PKG_ID}/debian/tinypilotjust before callingdh_install.debhelper also strictly requires a
changelogfile. We can't do a real changelog because we're creating a new Debian package for every commit to the main branch, and we don't want to have to manually upload the changelog on every change, so we just create a dummy changelog at build time.Note that with this change, the
changelogfile contains the page version rather than thecontrolfile, as it had been previously.I've diffed the package contents with this change against the
masterbuild and verified that the only delta is the addition of the file./usr/share/doc/tinypilot/changelog.gz.