Build TinyPilot Debian package and install bundle outside the main branch #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtlynch
changed the title
mtlynch
changed the title
Automated comment from CodeApprove ➜⏳ @jotaen4tinypilot please review this Pull Request |
jotaen4tinypilot
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
✔️ Approved
Is it possible to download the bundles from CircleCI?
👀 @mtlynch it's your turn please take a look
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adjusts filtering in CircleCI so that we build the TinyPilot Debian package and install bundle even in non-main repo branches.
Uploading a bundle changes state on our update server, so we should only do that in our main branch. But all the other steps are fine to run in branches because it doesn't affect state outside of CI. It's often useful to build packages or bundles in the branches if we want to test something end-to-end.