Remove reference to legacy USE_WEBRTC_REMOTE_SCREEN variable.
#1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automated comment from CodeApprove ➜⏳ @jotaen4tinypilot please review this Pull Request |
jotaen4tinypilot
approved these changes
Jan 9, 2023
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
✔️ Approved
Oh, cool that you noticed this! This should actually have been part of the upstream merge of #1166, but I apparently forgot that we had another instance of that variable in Pro back in the day.
Fortunately, this didn’t create a security problem here (video_service.py is currently used as part of the process of revoking user credentials in Pro): the env variable only refers to Janus-related logic, not to uStreamer – i.e., the restart of the latter wasn’t affected.
👀 @jdeanwallace it's your turn please take a look
jdeanwallace
added a commit
that referenced
this pull request
Jan 10, 2023
Part of #1249 This PR contains an exact copy of https://github.com/tiny-pilot/tinypilot-pro/blob/bc0707716f01fc3c5291ec2c320eb44daa97bb41/app/video_service.py Thanks to our [uStreamer launcher script](tiny-pilot/ansible-role-ustreamer#89), we now dynamically determine the correct uStreamer command-line options each time the systemd `ustreamer` service is started. That means we no longer need to run an ansible playbook to apply the video settings sitting in `/home/tinypilot/settings.yml`. Instead, we can just restart `ustreamer.service` to redetermine the correct video options. Seeing as we already have a `video_service` module in TinyPilot Pro that restarts uStreamer & Janus, I thought it would be a good idea to backport `video_service.py` to TinyPilot Community. ### Notes 1. I noticed that we're still referencing a [legacy environment variable: `USE_WEBRTC_REMOTE_SCREEN`](https://github.com/tiny-pilot/tinypilot-pro/blob/bc0707716f01fc3c5291ec2c320eb44daa97bb41/app/video_service.py#L16). I've fixed it in a [follow-up PR](#1255). <a data-ca-tag href="https://codeapprove.com/pr/tiny-pilot/tinypilot/1251"><img src="https://codeapprove.com/external/github-tag-allbg.png" alt="Review on CodeApprove" /></a>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1249
Depends on #1251
We no longer use the
USE_WEBRTC_REMOTE_SCREENenvironment variable and instead we save the current streaming mode to our local database.This PR removes the use of
USE_WEBRTC_REMOTE_SCREEN.