Adding frontend checks to build and CI

.circleci/config.yml

@@ -1,6 +1,6 @@
 version: 2.1
 jobs:
-  build:
+  build_python:
     docker:
       - image: circleci/python:3.7.3
     steps:
@@ -14,7 +14,18 @@ jobs:
             . venv/bin/activate
             pip install --requirement requirements.txt
             pip install --requirement dev_requirements.txt
-            ./run_build
+            ./dev-scripts/build-python
+  format_frontend:
+    docker:
+      - image: circleci/node:13.2.0-stretch
+    steps:
+      - checkout
+      - run:
+          name: Install prettier globally
+          command: npm install prettier@2.0.5
+      - run:
+          name: Check frontend formatting
+          command: ./dev-scripts/check-frontend-format
   e2e:
     machine:
       # A Debian image would be better, as it matches Raspberry Pi OS more
@@ -33,5 +44,6 @@ jobs:
 workflows:
   test:
     jobs:
-      - build
+      - build_python
+      - format_frontend
       - e2e

.gitignore

@@ -63,6 +63,10 @@ venv/
 *~
 *.sw?
 
+# Node
+node_modules
+package-lock.json
+
 # Mac OS
 *.DS_Store
 *.xcworkspace

.prettierignore

@@ -0,0 +1 @@
+app/static/third-party

README.md

@@ -93,20 +93,21 @@ After running these commands, you should be able to access TinyPilot through a w
 
 ## Developer installation
 
-If you're interesting in contributing to TinyPilot, follow these instructions to install the required developer packages in your development environment:
+If you're interested in contributing to TinyPilot, follow these instructions to install the required developer packages in your development environment:
 
 ```bash
 python3.7 -m venv venv
 . venv/bin/activate
 pip install --requirement requirements.txt
 pip install --requirement dev_requirements.txt
-hooks/enable_hooks
+
+npm install prettier@2.0.5
 ```
 
 To run TinyPilot's build scripts, run:
 
 ```bash
-./run_build
+./dev-scripts/build
 ```
 
 To enable TinyPilot's Git hooks, run:

dev-scripts/build

@@ -0,0 +1,13 @@
+#!/bin/bash
+
+# Exit build script on first failure.
+set -e
+
+# Echo commands to stdout.
+set -x
+
+# Exit on unset variable.
+set -u
+
+./dev-scripts/build-python
+./dev-scripts/check-frontend-format

dev-scripts/check-frontend-format

@@ -0,0 +1,12 @@
+#!/bin/bash
+
+# Exit build script on first failure.
+set -e
+
+# Echo commands to stdout.
+set -x
+
+# Exit on unset variable.
+set -u
+
+./node_modules/.bin/prettier --check app/static

hooks/pre-commit

@@ -1,5 +1,12 @@
 #!/bin/bash
 
-set -xue
+# Exit build script on first failure.
+set -e
 
-./run_build
+# Echo commands to stdout.
+set -x
+
+# Exit on unset variable.
+set -u
+
+./dev-scripts/build