Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic CircleCI config #5

Merged
merged 1 commit into from
May 11, 2023
Merged

Add basic CircleCI config #5

merged 1 commit into from
May 11, 2023

Conversation

jdeanwallace
Copy link
Contributor

@jdeanwallace jdeanwallace commented May 10, 2023

Related #3

To eventually build a uStreamer Debian package in CI, we first need basic CI config.

This PR copies the following scripts from the TinyPilot Community repo and executes them as CircleCI jobs:

Review on CodeApprove

@jdeanwallace jdeanwallace marked this pull request as ready for review May 10, 2023 19:13
@jdeanwallace
Copy link
Contributor Author

@mtlynch - can you enable CircleCI for this repo please? link

@mtlynch
Copy link
Contributor

mtlynch commented May 10, 2023

@jdeanwallace - Enabled!

@jotaen4tinypilot
Copy link

@mtlynch do we have to enable CodeApprove per repo? It didn’t seem to be available here, so I approved via Github.

@mtlynch
Copy link
Contributor

mtlynch commented May 11, 2023

@jotaen4tinypilot - Oh, yeah. I've just enabled it. I tried forcing it to create the review sticker in the PR description, but it doesn't seem to want to, but hopefully it works on future reviews

https://codeapprove.com/pr/tiny-pilot/ustreamer-debian/5

Copy link

@jotaen4tinypilot jotaen4tinypilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated comment from CodeApprove ➜

Approved on CodeApprove
✔️ Approved


👀 @jdeanwallace it's your turn please take a look

@jotaen4tinypilot
Copy link

Thanks!

I tried forcing it to create the review sticker in the PR description, but it doesn't seem to want to, but hopefully it works on future reviews

For me, the button / sticker shows up now: (maybe it was delayed?)

Screenshot 2023-05-11 at 14 50 15

@mtlynch
Copy link
Contributor

mtlynch commented May 11, 2023

@jotaen4tinypilot - Oh, yeah, showing up for me too now.

@jdeanwallace jdeanwallace merged commit 69d4e3d into master May 11, 2023
@jdeanwallace jdeanwallace deleted the ci branch May 11, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants