Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename pre-install script #8

Merged
merged 1 commit into from
May 25, 2023
Merged

Rename pre-install script #8

merged 1 commit into from
May 25, 2023

Conversation

jdeanwallace
Copy link
Contributor

@jdeanwallace jdeanwallace commented May 25, 2023

Related #3

This PR fixes a bug in our uStreamer Debian package where the pre-install script wasn't running because it was incorrectly named. Was ustreamer.preinstall should have been ustreamer.preinst (docs).

This means we'll need to cut another ustreamer-debian release 🤦‍♂️

Review on CodeApprove

Copy link
Contributor

@mtlynch mtlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated comment from CodeApprove ➜

Approved on CodeApprove
✔️ Approved

Nobody asked, but I approve anyway.


👀 @jdeanwallace it's your turn please take a look

@jdeanwallace jdeanwallace merged commit bc3d1a9 into master May 25, 2023
@jdeanwallace jdeanwallace deleted the preinst-script branch May 25, 2023 13:41
jdeanwallace added a commit that referenced this pull request May 25, 2023
Related #3
Dependent on #8

After installing our uStreamer Debian package, the man-pages didn't
work:
```bash
$ man ustreamer
No manual entry for ustreamer
```

This is because the uStreamer's man-pages were being copied to
`/opt/ustreamer` instead of `/usr/share/man`.

I've tested this on device.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants