Skip to content

Commit

Permalink
circleci: our version of misspell is no longer supported with go < 1.…
Browse files Browse the repository at this point in the history
…21, so disable lint in go 1.19 ci job

I jumped through quite a few hoops to get test-llvm15-go119 to work, but this last hoop seems not worth jumping through:

  cd internal/tools && go generate -tags tools ./
  /go/pkg/mod/github.com/golangci/misspell@v0.6.0/mime.go:10:2: package slices is not in GOROOT (/usr/local/go/src/slices)
  tools.go:12: running "go": exit status 1
  make: *** [GNUmakefile:952: tools] Error 1

I mean, we could patch misspell to not use slices, or to use the prerelease slices, but...
  • Loading branch information
dkegel-fastly authored and deadprogram committed Aug 13, 2024
1 parent 8135be4 commit e27b2c4
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ jobs:
steps:
- test-linux:
llvm: "15"
# "make lint" fails before go 1.21 because internal/tools/go.mod specifies packages that require go 1.21
fmt-check: false
resource_class: large
test-llvm18-go122:
docker:
Expand Down

0 comments on commit e27b2c4

Please sign in to comment.