Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transform: fix bug in StringToBytes optimization pass #3923

Merged
merged 1 commit into from
Sep 23, 2023

Commits on Sep 21, 2023

  1. transform: fix bug in StringToBytes optimization pass

    Previously, this pass would convert any read-only use of a
    runtime.stringToBytes call to use the original string buffer instead.
    This is incorrect: if there are any writes to the resulting buffer, none
    of the slice buffer pointers can be converted to use the original
    read-only string buffer.
    
    This commit fixes that bug and adds a test to prove the new (correct)
    behavior.
    aykevl committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    900e9f4 View commit details
    Browse the repository at this point in the history