Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darwin: replace custom syscall package with Go native syscall package #4417

Merged
merged 1 commit into from
Sep 4, 2024

Commits on Aug 22, 2024

  1. darwin: replace custom syscall package with Go native syscall package

    This required a few compiler and runtime tricks to work, but I ran a
    bunch of tests and it seems fine. (CI will of course do more exhaustive
    testing).
    
    The main benefit here is that we don't need to maintain the darwin
    version of the syscall package, and reduce extra risks for bugs (because
    we reuse the well-tested syscall package). For example, Go 1.23 needed a
    bunch of new constants in the syscall package. That would have been
    avoided if we had used the native syscall package on MacOS.
    aykevl committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    1b1943b View commit details
    Browse the repository at this point in the history