-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compiler: conform to latest iteration of wasm types proposal #4501
Open
ydnar
wants to merge
11
commits into
tinygo-org:dev
Choose a base branch
from
ydnar:ydnar/wasm-types
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golang/go#66984 - Remove int and uint as allowed types in params, results, pointers, or struct fields - Only allow small integers in pointers, arrays, or struct fields
ydnar
changed the title
compiler: update to latest version of wasm types proposal
compiler: conform to latest iteration of wasm types proposal
Oct 5, 2024
golang/go#66984 TODO: regenerate WASI syscall packages for GC shape types including structs.HostLayout
…d regenerate Go bindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to current version of the wasm types proposal at golang/go#66984.
Changes include:
int
anduint
as allowed types.int8
,uint8
,int16
, anduint16
to struct fields, arrays, or pointer values.struct
types in wasm params with 1 or more fields to includestructs.HostLayout
. It enforces this for Go 1.23 or later.wasm-tools-go
to v0.3.0 and regenerates the WASI 0.2 internal packages.TODO: add wasm type tests for
//go:wasmexport
?