Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler: conform to latest iteration of wasm types proposal #4501

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

ydnar
Copy link
Contributor

@ydnar ydnar commented Oct 5, 2024

Updates to current version of the wasm types proposal at golang/go#66984.

Changes include:

  • Removal of int and uint as allowed types.
  • Restriction of int8, uint8, int16, and uint16 to struct fields, arrays, or pointer values.
  • Requires struct types in wasm params with 1 or more fields to include structs.HostLayout. It enforces this for Go 1.23 or later.
    • TODO: revise this to minimum Go 1.24?
  • Bumps wasm-tools-go to v0.3.0 and regenerates the WASI 0.2 internal packages.

TODO: add wasm type tests for //go:wasmexport?

golang/go#66984

- Remove int and uint as allowed types in params, results, pointers, or struct fields
- Only allow small integers in pointers, arrays, or struct fields
@ydnar ydnar changed the title compiler: update to latest version of wasm types proposal compiler: conform to latest iteration of wasm types proposal Oct 5, 2024
@ydnar
Copy link
Contributor Author

ydnar commented Oct 7, 2024

@dgryski @aykevl would you prefer I split this into two parts, one that upgrades the wasm-tools-go dependency and regenerates the bindings, and a separate one with the wasm types changes to package compiler?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant