Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: throws #51

Merged
merged 5 commits into from
Oct 17, 2023
Merged

feat: throws #51

merged 5 commits into from
Oct 17, 2023

Conversation

Aslemammad
Copy link
Member

@Aslemammad Aslemammad commented Jul 23, 2023 •
edited
Loading

Resolves #47

@Aslemammad Aslemammad linked an issue Jul 23, 2023 that may be closed by this pull request
Move types/index.d.ts to src/types.ts #49
Closed
@github-actions
Copy link

github-actions bot commented Jul 23, 2023 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/index.js 2.5 KB (+2.37% 🔺) 50 ms (+2.37% 🔺) 91 ms (-43.9% 🔽) 141 ms
dist/index.cjs 2.75 KB (+2.07% 🔺) 55 ms (+2.07% 🔺) 92 ms (-12.22% 🔽) 147 ms

@Aslemammad Aslemammad mentioned this pull request Jul 23, 2023
Closed
@sirenkovladd
Copy link
Member

Could you fix the error in ./src/event.ts ?

@Aslemammad
Copy link
Member Author

@sirenkovladd Hey, What do you mean?

@sirenkovladd
Copy link
Member

tinybench/src/event.ts

Line 1 in 8d7bbfd

import type { BenchEvents } from '../types';

->

import type { BenchEvents } from './types';

@Aslemammad
Copy link
Member Author

@sirenkovladd thank you so much.

@Aslemammad Aslemammad mentioned this pull request Oct 17, 2023
Closed
@Aslemammad Aslemammad merged commit ab950e0 into main Oct 17, 2023
5 checks passed
@Aslemammad Aslemammad deleted the feat/throws-and-types branch October 17, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move types/index.d.ts to src/types.ts Is there a reason that bench.run() doesn't throw?
2 participants
@Aslemammad @sirenkovladd