feature: template function #53
Merged
+70
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ak1ra24
force-pushed
the
feature/template
branch
from
7974ad4
to
72e1e25
Compare
slankdev
reviewed
Aug 23, 2020
slankdev
reviewed
Aug 24, 2020
Comment on lines
+84
to
+88
| type Template struct { | ||
| Src string `yaml:"src"` | ||
| Dst string `yaml:"dst"` | ||
| Content string `yaml:"content"` | ||
| } |
There was a problem hiding this comment.
これもだだの今後の議論ポイントとして.
もしかすると, 以下のようでもよかったかもしれないね.
両方(content, src) が両方選択されると, 片方は無視されるだけだけど, 指定されたかどうかとかは, mapとしてはpointer使ってその辺を整理出来るようにする方法もあると思う.
今は十分だと思うからこれでいいけど. ポイントとして.
type Template struct {
Src *string
Dst *string
Content *string
}
|
全然関係ないけどPRごとに, buildしてbinaryをこのconversationに添付するロボットがほしい. |
slankdev
reviewed
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#52