-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: template function #53
Conversation
7974ad4
to
72e1e25
Compare
type Template struct { | ||
Src string `yaml:"src"` | ||
Dst string `yaml:"dst"` | ||
Content string `yaml:"content"` | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これもだだの今後の議論ポイントとして.
もしかすると, 以下のようでもよかったかもしれないね.
両方(content, src) が両方選択されると, 片方は無視されるだけだけど, 指定されたかどうかとかは, mapとしてはpointer使ってその辺を整理出来るようにする方法もあると思う.
今は十分だと思うからこれでいいけど. ポイントとして.
type Template struct {
Src *string
Dst *string
Content *string
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
一つだけ. 他はこのままでいいと思う.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1つだけ.
これ以外は問題ないと思う.
全然関係ないけどPRごとに, buildしてbinaryをこのconversationに添付するロボットがほしい. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
もう一つあった.
と思ったけど.
少なくとも os.Openは使わないといけないのか... 仕方ないか.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#52