dump: don't dump data for view (pingcap#227)

tisonkun · Dec 30, 2020 · b7671b6 · b7671b6
1 parent 2d79697
commit b7671b6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/dumpling/tests/views/run.sh b/dumpling/tests/views/run.sh
@@ -20,4 +20,5 @@ file_not_exist "$DUMPLING_OUTPUT_DIR/views.v-schema-view.sql"
 run_dumpling --no-views=false
 #diff "$DUMPLING_BASE_NAME/data/views-schema-create.sql" "$DUMPLING_OUTPUT_DIR/views-schema-create.sql"
 diff "$DUMPLING_BASE_NAME/data/views.v-schema.sql" "$DUMPLING_OUTPUT_DIR/views.v-schema.sql"
-diff "$DUMPLING_BASE_NAME/data/views.v-schema-view.sql" "$DUMPLING_OUTPUT_DIR/views.v-schema-view.sql"
+diff "$DUMPLING_BASE_NAME/data/views.v-schema-view.sql" "$DUMPLING_OUTPUT_DIR/views.v-schema-view.sql"
+file_not_exist "$DUMPLING_BASE_NAME/data/views.v.000000000.sql"
diff --git a/dumpling/v4/export/dump.go b/dumpling/v4/export/dump.go
@@ -270,10 +270,10 @@ func (d *Dumper) dumpDatabases(metaConn *sql.Conn, taskChan chan<- Task) error {
 			} else {
 				task := NewTaskTableMeta(dbName, table.Name, meta.ShowCreateTable())
 				d.sendTaskToChan(task, taskChan)
-			}
-			err = d.dumpTableData(metaConn, meta, taskChan)
-			if err != nil {
-				return err
+				err = d.dumpTableData(metaConn, meta, taskChan)
+				if err != nil {
+					return err
+				}
 			}
 		}
 	}