-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requiring 'rake/file_list' in gemspec breaks the Gemfile if rake is not already installed #184
Comments
Hey, I'm sorry for having caused this! 😪 What do you think? |
Giving more thoughts into this, there are a few options here:
From the Debian side, all we care about is to not use |
@utkarsh2102 Thanks for the prompt response! I personally like option 2 - using |
This also fixes all the CI inconsistencies. Fixes: titusfortner#184 Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
This also fixes all the CI inconsistencies. Fixes: titusfortner#184 Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
Hi @kapoorlakshya,
Opened PR #185 for this^ |
Thank you! Closed by #185. |
Summary
#179 added use of
rake/file_list
which breaks theGemfile
via the use ofbundle install/update
ifrake
is not already installed. This is especially problematic on CI systems where we always start from a clean state.@utkarsh2102 Could you please take a look at this when you have time? I could attempt to fix this, but don't want to inadvertently break your Debian specific pipeline. Thank you!
CI Failure
https://travis-ci.org/github/titusfortner/webdrivers/builds/727632931
No errors on Appveyor (example) because it has
rake
v12.0 pre-installed as part of the CI image.Workaround
Install rake 12.x prior to bundle install/update -
gem install rake -v 12.3.3
The text was updated successfully, but these errors were encountered: