implements driver caching #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
twalpole
reviewed
May 7, 2019
lib/webdrivers/common.rb
Outdated
| @@ -120,7 +124,7 @@ def sufficient_binary? | |||
| end | |||
|
|
|||
| def normalize_version(version) | |||
| Gem::Version.new(version.to_s) | |||
| Gem::Version.new(version.nil? ? nil : version.to_s) | |||
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a
#{driver_path}.versionfile, and we read its modified date on the first lookup. There might still be a race condition, but I think it'll solve #77 well enough?The idea is to set the default value in 3.x to 0, but allow people to set it if they want.
Then 4.x will be set by default to 1 day (86_400)
Note that for Chrome if a major browser version update has happened, it will ignore the cache, so effectively this is only preventing using a newer point release up to the expiration of the
cache_time