-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The warning about caching won't go away #118
Comments
You're right, I didn't put the correct conditional here. I'm hoping we get 4.0 beta released soon, and a production release soon after. I'm leaning toward that than another point release fixing this. |
Fixed with #121 and released in 3.9.3 |
I updated to version 3.9.3 and I am still getting the warning. |
Yes. still got this warning. Is there any chance to re-open this issue? |
I am still seeing the warning in 3.9.3 |
This is what I get for not making sure there was a test. Let me look. |
Thanks Titus |
3.9.4 released (with spec) should be good now. |
Maybe I'm missing something, but I updated to 3.9.4 and I'm still getting the warning even after running my tests multiple times. |
Nevermind, I set a value for cache_time and the warning doesn't appear. |
The README still says:
It suggests there is a default, which suggests if you want the default you don't need to set it manually. But the deprecation warning suggests Webdrivers wants you to set it manually, and in the future you will have to set it manually and there will be no default. Can you update the README to explain what it is suggested one does? I think one has to put that configure line somewhere in one's app (perhaps test_helper.rb or spec_helper.rb) and perhaps it is suggested you set it to 86_400? |
Hey @jrochkind, which version of the gem are you using? The cache time warning was removed in v4.0 and the value was properly defaulted to 24 hours in v4.0.1.
|
Aha, I am using 3.94. Sounds like it's time to update to 4.0, ok! I put |
Summary
I keep getting the warning:
I have tried to set
Webdrivers.cache_time= ...
at various points in the test suite initialization without success.Debug Info
Please provide the following information for bug reports:
Expected Behavior
The warning to go away
Actual Behavior
It doesn't
The text was updated successfully, but these errors were encountered: