Disable warning about caching in 4.x when setting `Webdrivers.cache_t… #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ime` Allows consumers of the gem to remove the warning when manually setting `Webdrivers.cache_time`.
|
@titusfortner thanks! |
|
Oh, my comment didn't go through. This is better than what I had written, thanks for the PR. Just released 3.9.3 which includes this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I recently updated to webdrivers v3.9.2 and found that setting
Webdrivers.cache_timeas mentioned in the warning about caching doesn't remove the warning. This was kind of confusing and could be a problem on teams that are fastidious about ensuring there are no warnings or deprecations when running tests.I looked through the tests and didn't see anywhere that it made sense to add test coverage. I see the behavior around
cache_timeis checked, but nothing forcache_warning. Let me know if test coverage is a must for PRs.Thanks for the work on this gem.