Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow selenium-webdriver 4.0.0 #218

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Allow selenium-webdriver 4.0.0 #218

merged 1 commit into from
Oct 14, 2021

Conversation

yahonda
Copy link
Contributor

@yahonda yahonda commented Oct 14, 2021

This pull request resolves the Rails issue rails/rails#43455

Since selenium-webdriver 4.0.0 has been released, webdriver 4.6 is not allowed
likely due to version limitation in webdrivers.gemspec.

  • bundle install failure at Rails issue 43455
$ bundle install
Warning: the running version of Bundler (2.2.22) is older than the version that created the lockfile (2.2.29). We suggest you to upgrade to the version that created the lockfile by running `gem install bundler:2.2.29`.
Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies.........
Bundler could not find compatible versions for gem "selenium-webdriver":
  In Gemfile:
    selenium-webdriver (>= 4.0.0.alpha7)

    webdrivers was resolved to 4.6.0, which depends on
      selenium-webdriver (>= 3.0, < 4.0)

Could not find gem 'selenium-webdriver (>= 3.0, < 4.0)', which is required by gem 'webdrivers', in source at
`/home/yahonda/src/github.com/SeleniumHQ/selenium`.

Bundler could not find compatible versions for gem "webdrivers":
  In snapshot (Gemfile.lock):
    webdrivers (= 4.6.0)

  In Gemfile:
    webdrivers

Running `bundle update` will rebuild your snapshot from scratch, using only
the gems in your Gemfile, which may resolve the conflict.
$

Refer
https://rubygems.org/gems/selenium-webdriver/versions/4.0.0

This pull request will resolves the Rails issue rails/rails#43455

Since `selenium-webdriver` 4.0.0 has been released, webdriver 4.6 is not allowed
likely due to version limitation in `webdrivers.gemspec`.

* bundle install failure at Rails issue 43455
```
$ bundle install
Warning: the running version of Bundler (2.2.22) is older than the version that created the lockfile (2.2.29). We suggest you to upgrade to the version that created the lockfile by running `gem install bundler:2.2.29`.
Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies.........
Bundler could not find compatible versions for gem "selenium-webdriver":
  In Gemfile:
    selenium-webdriver (>= 4.0.0.alpha7)

    webdrivers was resolved to 4.6.0, which depends on
      selenium-webdriver (>= 3.0, < 4.0)

Could not find gem 'selenium-webdriver (>= 3.0, < 4.0)', which is required by gem 'webdrivers', in source at
`/home/yahonda/src/github.com/SeleniumHQ/selenium`.

Bundler could not find compatible versions for gem "webdrivers":
  In snapshot (Gemfile.lock):
    webdrivers (= 4.6.0)

  In Gemfile:
    webdrivers

Running `bundle update` will rebuild your snapshot from scratch, using only
the gems in your Gemfile, which may resolve the conflict.
$
```

Refer
https://rubygems.org/gems/selenium-webdriver/versions/4.0.0
@yahonda
Copy link
Contributor Author

yahonda commented Oct 14, 2021

Here is the minimum case to reproduce.

  • Gemfile
source "https://rubygems.org"

gem "webdrivers", "=4.6.1"
gem "selenium-webdriver", "=4.0.0"
$ ruby -v
ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [x86_64-linux]
$ bundle
Fetching gem metadata from https://rubygems.org/.......
Resolving dependencies...
Bundler could not find compatible versions for gem "selenium-webdriver":
  In Gemfile:
    selenium-webdriver (= 4.0.0)

    webdrivers (= 4.6.1) was resolved to 4.6.1, which depends on
      selenium-webdriver (>= 3.0, < 4.0)
$

@titusfortner titusfortner merged commit b4f4f3c into titusfortner:main Oct 14, 2021
@titusfortner
Copy link
Owner

Yes, thanks for the contribution, few other problems that needed fixing. I'll get a release out shortly.

yahonda added a commit to yahonda/rails that referenced this pull request Oct 14, 2021
@yahonda yahonda deleted the allow_selenium-webdriver_400 branch October 15, 2021 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants