Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download correct geckdriver file on Apple Silicon #234

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

stephannv
Copy link
Contributor

@stephannv stephannv commented Aug 3, 2022

Geckodriver splits its Mac OS files into 2 versions (macos.tar.gz and macos-aarch64.tar.gz), and webdrivers doesn't work properly if macos.tar.gz is used on Apple Sillicon platform.
Geckodriver releases: https://github.com/mozilla/geckodriver/releases

@kapoorlakshya
Copy link
Collaborator

@stephannv Thanks for your contribution! Can you please add a test for this and rebase on main? I just fixed two broken tests and CI checks should be green now.

@stephannv
Copy link
Contributor Author

Done @kapoorlakshya.

Geckodriver splits its Mac OS files into 2 versions (macos.tar.gz and macos-aarch64.tar.gz), and webdriver doesn't work properly if `macos.tar.gz` is used on Apple Sillicon platform.
Geckodriver releases: https://github.com/mozilla/geckodriver/releases
@stephannv
Copy link
Contributor Author

Specs fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants