Fixed Webdrivers::VersionError with chrome version greater than 115 #249

sadahiro-ono · 2023-07-27T09:48:04Z

similar Issue: #247

f the version is 115 or higher, the API can be used, so if the version is 115 or higher, the stable version is obtained and downloaded from the API.

refarence

titusfortner · 2023-07-27T17:55:06Z

Thanks for the PR. It looks like it isn't backwards compatible. Can you look at why the tests are failing?

sadahiro-ono · 2023-07-28T10:12:49Z

@titusfortner
Local tests passed, but I made some fixes to lower the impact, could you please run a CI?

sadahiro-ono · 2023-07-28T13:34:31Z

@titusfortner
The main branch is also not passing the tests. I sorry, Could you please confirm this for me?
https://github.com/titusfortner/webdrivers/actions/runs/5683791993/job/15405104246

alexshenia · 2023-07-28T15:11:26Z

expected StandardError with message matching /Net::HTTPServerException: 404 "Not Found"/, got #<Webdrivers::NetworkError: Net::HTTPClientException: 404 "Not Found" with https://github.com/mozilla/geckodriver/releases/download/v0.2.0/geckodriver-v0.2.0-linux64.tar.gz>

Just need to change from StandardError to Webdrivers::NetworkError

alexshenia · 2023-07-28T15:17:05Z

Webdrivers::NetworkError: Net::HTTPClientException: 404 "Not Found" with https://msedgedriver.azureedge.net/114.0.1823.90/edgedriver_mac64.zip
https://msedgedriver.azureedge.net/ does not have this build 114.0.1823.90/edgedriver_mac64.zip

titusfortner · 2023-07-28T15:42:10Z

StandardError is the superclass, it is the value of the String it failed on. Not sure if it is happenstance or common that MS doesn't do releases for all platforms for all patch versions, but not good either way.

titusfortner

Thanks for putting this together and adding tests
I really hate looking at old code I've written.
We probably need to exclude chromedriver.rb from Metrics/ClassLength in .rubocop.yml.

titusfortner · 2023-07-28T20:44:15Z

lib/webdrivers/chromedriver.rb

@@ -77,8 +81,14 @@ def latest_point_release(version)
          "#{msg} A network issue is preventing determination of latest chromedriver release."
        end

+        url = if version >= normalize_version('115')


We can use https://chromedriver.chromium.org/downloads/version-selection for the error message

lib/webdrivers/chromedriver.rb

titusfortner · 2023-07-28T20:53:23Z

lib/webdrivers/chromedriver.rb

@@ -149,6 +172,33 @@ def sufficient_binary?
        super && current_version && (current_version < normalize_version('70.0.3538') ||
          current_build_version == browser_build_version)
      end
+
+      def chrome_for_testing_base_url


Not sure if it matters, but this breaks https://github.com/titusfortner/webdrivers/wiki/Using-with-VCR-or-WebMock

Do we need to support a version that we cannot get from this endpoint?
I believe we can change the base_url to the API endpoint if we don't need it.

yes, we still need to support the older versions

titusfortner · 2023-07-28T21:26:40Z

lib/webdrivers/chromedriver.rb

@@ -115,7 +134,11 @@ def driver_filename(driver_version)
        elsif System.platform == 'linux'
          'linux64'
        elsif System.platform == 'mac'
-          apple_filename(driver_version)
+          if driver_version >= normalize_version('115')


If we move this conditional to #apple_filename we don't need to add #apple_filename_api.

yykamei · 2023-07-31T00:15:41Z

spec/webdrivers/chromedriver_spec.rb

@@ -66,7 +66,7 @@
        allow(Net::HTTP).to receive(:get_response).and_raise(SocketError)
        allow(chromedriver).to receive(:exists?).and_return(false)

-        msg = %r{Can not reach https://chromedriver.storage.googleapis.com}
+        msg = %r{Can not reach https://googlechromelabs.github.io/chrome-for-testing/latest-patch-versions-per-build.json}


How about considering the both cases for v115+ and v114 or earlier? The Gem is expected to print "Can not reach ...", and the target URL is not important here.

Suggested change

msg = %r{Can not reach https://googlechromelabs.github.io/chrome-for-testing/latest-patch-versions-per-build.json}

msg = %r{Can not reach (?:https://googlechromelabs.github.io|https://chromedriver.storage.googleapis.com)}

yykamei · 2023-07-31T00:15:52Z

spec/webdrivers/chromedriver_spec.rb

@@ -101,7 +101,7 @@
      it 'raises ConnectionError if offline' do
        allow(Net::HTTP).to receive(:get_response).and_raise(SocketError)

-        msg = %r{Can not reach https://chromedriver.storage.googleapis.com/}
+        msg = %r{Can not reach https://googlechromelabs.github.io/chrome-for-testing/latest-patch-versions-per-build.json}


Suggested change

msg = %r{Can not reach https://googlechromelabs.github.io/chrome-for-testing/latest-patch-versions-per-build.json}

msg = %r{Can not reach (?:https://googlechromelabs.github.io|https://chromedriver.storage.googleapis.com)}

yykamei · 2023-07-31T00:19:23Z

spec/webdrivers/chromedriver_spec.rb

@@ -223,11 +241,12 @@
    it 'raises ConnectionError when offline' do
      allow(Net::HTTP).to receive(:get_response).and_raise(SocketError)

-      msg = %r{^Can not reach https://chromedriver.storage.googleapis.com}
+      msg = %r{^Can not reach https://googlechromelabs.github.io/chrome-for-testing/latest-patch-versions-per-build.json}


Suggested change

msg = %r{^Can not reach https://googlechromelabs.github.io/chrome-for-testing/latest-patch-versions-per-build.json}

msg = %r{Can not reach (?:https://googlechromelabs.github.io|https://chromedriver.storage.googleapis.com)}

titusfortner · 2023-07-31T19:33:20Z

Merged here — 97fb1e2

Thank you!

titusfortner force-pushed the bugfix_chromedriver branch from 9ef214c to de1dffc Compare July 27, 2023 17:49

sadahiro-ono added 15 commits July 28, 2023 10:39

Bugfix ChromeDriver

fa6c87e

fix url

e19d997

fix

0ad4015

miss

9b0cb30

refactor

928481e

chrome to chromedriver

184e9a1

refactor unzip_file

4e62a4d

check 115

2d2525e

>=

30c7bb1

fix test

0a35745

add test

369e301

add test when using an Apple machine

345006d

try fix test

5bd1aa6

fix chro

cd456f9

fix chro

4378b7d

titusfortner force-pushed the bugfix_chromedriver branch from 8438f32 to 4378b7d Compare July 28, 2023 15:39

titusfortner requested changes Jul 28, 2023

View reviewed changes

titusfortner reviewed Jul 28, 2023

View reviewed changes

titusfortner mentioned this pull request Jul 28, 2023

update readme with future plans #251

Merged

samholst mentioned this pull request Jul 28, 2023

Latest Google Webdriver update breaking changes #252

Closed

titusfortner mentioned this pull request Jul 30, 2023

Webdrivers trying to load a Chrome version that doesn't exist #247

Closed

yykamei reviewed Jul 31, 2023

View reviewed changes

Merge branch 'main' into bugfix_chromedriver

55ddd51

titusfortner closed this Jul 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed Webdrivers::VersionError with chrome version greater than 115 #249

Fixed Webdrivers::VersionError with chrome version greater than 115 #249

sadahiro-ono commented Jul 27, 2023

titusfortner commented Jul 27, 2023

sadahiro-ono commented Jul 28, 2023

sadahiro-ono commented Jul 28, 2023

alexshenia commented Jul 28, 2023 •

edited

Loading

alexshenia commented Jul 28, 2023

titusfortner commented Jul 28, 2023

titusfortner left a comment

titusfortner Jul 28, 2023

titusfortner Jul 28, 2023

sadahiro-ono Jul 31, 2023

titusfortner Jul 31, 2023

titusfortner Jul 28, 2023

yykamei Jul 31, 2023 •

edited

Loading

yykamei Jul 31, 2023 •

edited

Loading

yykamei Jul 31, 2023 •

edited

Loading

titusfortner commented Jul 31, 2023

	msg = %r{Can not reach https://googlechromelabs.github.io/chrome-for-testing/latest-patch-versions-per-build.json}
	msg = %r{Can not reach (?:https://googlechromelabs.github.io\|https://chromedriver.storage.googleapis.com)}

	msg = %r{^Can not reach https://googlechromelabs.github.io/chrome-for-testing/latest-patch-versions-per-build.json}
	msg = %r{Can not reach (?:https://googlechromelabs.github.io\|https://chromedriver.storage.googleapis.com)}

Fixed Webdrivers::VersionError with chrome version greater than 115 #249

Fixed Webdrivers::VersionError with chrome version greater than 115 #249

Conversation

sadahiro-ono commented Jul 27, 2023

titusfortner commented Jul 27, 2023

sadahiro-ono commented Jul 28, 2023

sadahiro-ono commented Jul 28, 2023

alexshenia commented Jul 28, 2023 • edited Loading

alexshenia commented Jul 28, 2023

titusfortner commented Jul 28, 2023

titusfortner left a comment

Choose a reason for hiding this comment

titusfortner Jul 28, 2023

Choose a reason for hiding this comment

titusfortner Jul 28, 2023

Choose a reason for hiding this comment

sadahiro-ono Jul 31, 2023

Choose a reason for hiding this comment

titusfortner Jul 31, 2023

Choose a reason for hiding this comment

titusfortner Jul 28, 2023

Choose a reason for hiding this comment

yykamei Jul 31, 2023 • edited Loading

Choose a reason for hiding this comment

yykamei Jul 31, 2023 • edited Loading

Choose a reason for hiding this comment

yykamei Jul 31, 2023 • edited Loading

Choose a reason for hiding this comment

titusfortner commented Jul 31, 2023

alexshenia commented Jul 28, 2023 •

edited

Loading

yykamei Jul 31, 2023 •

edited

Loading

yykamei Jul 31, 2023 •

edited

Loading

yykamei Jul 31, 2023 •

edited

Loading