Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note that only supported on node 8 and above #1053

Merged
merged 2 commits into from
Sep 30, 2019

Conversation

shadowspawn
Copy link
Collaborator

Pull Request

Problem

We do not have a stated policy for node support, and have long wanted to be able to use some new javascript language features. I would like to be clear for myself what we can and can't use without breaking clients.

Related issue is #1045

Solution

Say that we only support node 8 and higher in the README.

As per #1045, I suggest we actually stick to features supported by node 6 for now.

(I deliberately have not put node 8 as an actual requirement in the engines field in the package.json since we are still work on older versions at least currently.)

@shadowspawn shadowspawn added this to the v4.0.0 milestone Sep 22, 2019
@shadowspawn
Copy link
Collaborator Author

I had a second go, and moved this under the Support section instead of Installation. I also added a comment about the Issues page, partly to balance the TideLift info.

(I don't think Support would be the right place if we enforced the allowed Node version, but feels a reasonable fit since we are saying what we support rather than what is compatible.)

Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shadowspawn shadowspawn merged commit 3f7ef66 into tj:develop Sep 30, 2019
@shadowspawn shadowspawn deleted the feature/node-8 branch September 30, 2019 06:47
cscott added a commit to cscott/seek-bzip that referenced this pull request Jul 31, 2020
Because of the bump in mocha version to 8.0, we can no longer run tests
on Node.js v8.x and below: mochajs/mocha#4164

The fibers package at version 5.0 also doesn't support Node.js v10.x
or lower, although it seems to work fine in my limited testing.

The commander package requires node 6 or greater:
tj/commander.js#1053
cscott added a commit to cscott/seek-bzip that referenced this pull request Jul 31, 2020
This version drops compatibility for Node.js <= 10.x, and as such is a
semver major version bump.

To be clear, the code in this package hasn't changed; we've just
bumped the versions of dependencies.  The `commander` dep requires
node 6 ( tj/commander.js#1053 ) but the dev
dependencies require Node.js <= 8.x and are unsupported on Node.js <=
10.x.  I can't promise that things that aren't being tested continue
to work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants