Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use npm ci with CI #1164

Merged
merged 1 commit into from
Feb 2, 2020
Merged

Conversation

abetomo
Copy link
Collaborator

@abetomo abetomo commented Feb 1, 2020

Pull Request

Problem

Better use npm ci.
https://docs.npmjs.com/cli/ci.html

Solution

Change CI setting from install to ci

ChangeLog

@abetomo abetomo requested a review from shadowspawn February 1, 2020 08:20
Copy link
Collaborator

@shadowspawn shadowspawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shadowspawn
Copy link
Collaborator

Oops, missed actually clicking approve the first time. 😄

@shadowspawn shadowspawn merged commit e5f316f into tj:develop Feb 2, 2020
@shadowspawn
Copy link
Collaborator

I have added 4.1.1 entry to CHANGELOG and bumped version. Not tagged yet.

I think ready to merge develop to master and release 4.1.1 @abetomo

No rush, when convenient for you.

@abetomo abetomo deleted the feature/use_npm-ci_with_ci branch February 2, 2020 02:54
@abetomo
Copy link
Collaborator Author

abetomo commented Feb 3, 2020

Thank you.
4.1.1 has been released.

@shadowspawn
Copy link
Collaborator

Looks good, thanks @abetomo 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants