Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parse result test #1188

Merged
merged 2 commits into from
Feb 12, 2020

Conversation

shadowspawn
Copy link
Collaborator

Pull Request

Problem

No tests on what .parse() and .parseAsync() return, and we recently changed what .parseAsync() returns.

Solution

Add simple tests.

Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shadowspawn shadowspawn merged commit 733047f into tj:develop Feb 12, 2020
@shadowspawn shadowspawn deleted the feature/add-parse-result-test-2 branch February 12, 2020 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants