Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for variadic to choices #1454

Merged
merged 1 commit into from
Jan 31, 2021

Conversation

shadowspawn
Copy link
Collaborator

@shadowspawn shadowspawn commented Jan 31, 2021

Pull Request

I don't this will be very common, but it is a shortcoming and did get reported!

Problem

Variadic and choices do not play well together.

Related: #1447

Solution

Add support for variadic to choices using same code as plain variadic processing.

(This does not add public support for mixing custom option processing with variadic. Keep it private until clearer what people might want to do.)

ChangeLog

Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants