Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support subcommands on windows. Fixes #142 #173

Merged
merged 1 commit into from
Feb 25, 2014
Merged

support subcommands on windows. Fixes #142 #173

merged 1 commit into from
Feb 25, 2014

Conversation

yiminghe
Copy link
Contributor

No description provided.

@ajb
Copy link

ajb commented Feb 22, 2014

Can this get pulled? 🌠

@tj
Copy link
Owner

tj commented Feb 25, 2014

missed this one, looks good to me

tj added a commit that referenced this pull request Feb 25, 2014
support subcommands on windows. Fixes #142
@tj tj merged commit b970a44 into tj:master Feb 25, 2014
@tj
Copy link
Owner

tj commented Feb 25, 2014

hmm we have a test failing now, I'll have to check that out later unless someone wants to take a look

zhiyelee added a commit to zhiyelee/commander.js that referenced this pull request Dec 14, 2014
Almost revert tj#173 which lead to the bug in tj#306
zhiyelee added a commit to zhiyelee/commander.js that referenced this pull request Jan 8, 2015
Almost revert tj#173 which lead to the bug in tj#306
zhiyelee added a commit to zhiyelee/commander.js that referenced this pull request Jan 10, 2015
solve tj#306, and bin in $PATH make sense now tj#196
Almost revert tj#173 which lead to the bug in tj#306

Also remove deprecated customFds option in spawn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants