Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make version flags configurable #22

Merged
merged 2 commits into from
Oct 31, 2011
Merged

Conversation

felixge
Copy link
Contributor

@felixge felixge commented Oct 31, 2011

I would like to use '-v' for '--verbose' and only expose version as
'--version'. This change allows me to do this without changing the
defaults for everybody else.

I would like to use '-v' for '--verbose' and only expose version as
'--version'. This change allows me to do this without changing the
defaults for everybody else.
@tj
Copy link
Owner

tj commented Oct 31, 2011

maybe we should change the default to -V or now that we have the long opts thing just --version only. pretty common to use -v for verbose so that would be fine with me!

@felixge
Copy link
Contributor Author

felixge commented Oct 31, 2011

maybe we should change the default to -V or now that we have the long opts thing just --version only. pretty common to use -v for verbose so that would be fine with me!

+1 on changing the default to '--version' only. But I'd still like it to be configurable as suggested by this patch.

--fg

tj added a commit that referenced this pull request Oct 31, 2011
@tj tj merged commit 060c5d3 into tj:master Oct 31, 2011
@felixge
Copy link
Contributor Author

felixge commented Nov 1, 2011

Awesome, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants