Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP resolves #649 switch to a modern test infrastructure #755

Closed
wants to merge 1 commit into from

Conversation

mojavelinux
Copy link
Contributor

This PR will hopefully kick off the migration to a modern test infrastructure. There are still many tests to rewrite. But we first need to decide whether ava is the right choice for this project. Then we can divide and conquer to finish migrating the tests.

The tests are temporarily stored in the test-ava folder until the old tests are cleared out of the way.

Use the following command to run the tests:

npm run ava

@mojavelinux
Copy link
Contributor Author

Thoughts?

@abetomo
Copy link
Collaborator

abetomo commented Jan 24, 2018

I think that there is no problem in selecting ava.

@mojavelinux
Copy link
Contributor Author

👍

I will continue adding a few more test cases. I'm sure it will raise some questions.

@shadowspawn
Copy link
Collaborator

(Adding link to #649 for easier clicking.)

@shadowspawn shadowspawn mentioned this pull request Apr 16, 2019
3 tasks
@CheshireSwift
Copy link

I have minor quibbles with ava, but not enough to want to bikeshed about it. I'd say go for it 👍

@shadowspawn
Copy link
Collaborator

I like Jest. The main advantage for Commander is it is much more widely used than Ava, so will be familiar to more people contributing to Commander. The main personal advantage is that Jest is the testing framework I use at work and at home!

I'm working on the conversion in #1035

Are you still ok with Jest @abetomo ?
#661 (comment)

@abetomo
Copy link
Collaborator

abetomo commented Sep 2, 2019

I think Jest is better.

@shadowspawn
Copy link
Collaborator

Closing in favour of #1035. Started move to Jest.

Thank you for your contributions.

@shadowspawn shadowspawn closed this Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants