Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.d.ts #930

Merged
merged 3 commits into from
Mar 15, 2019
Merged

Update index.d.ts #930

merged 3 commits into from
Mar 15, 2019

Conversation

kira1928
Copy link
Contributor

Add the optional parameter argsDescription to description() function

Add the optional parameter `argsDescription` to description() function
@abetomo abetomo requested a review from shadowspawn March 14, 2019 03:41
@shadowspawn
Copy link
Collaborator

@kira1928
Would it be appropriate to have type matching what I think is the expected use:

{{[argName: string]: string}}

rather than the pure object style definition:

{{[key: string]: any}}

@kira1928
Copy link
Contributor Author

kira1928 commented Mar 14, 2019

@shadowspawn
Thank you for your advice.
I have fixed the problem you mentioned.
Does it look better now?

Copy link
Collaborator

@shadowspawn shadowspawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

@abetomo
Copy link
Collaborator

abetomo commented Mar 15, 2019

Thank you!

@abetomo abetomo merged commit 291fc04 into tj:master Mar 15, 2019
@kira1928 kira1928 deleted the update-index.d.ts branch March 15, 2019 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants