Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unique #103

Open
tjmehta opened this issue Jul 1, 2015 · 2 comments
Open

unique #103

tjmehta opened this issue Jul 1, 2015 · 2 comments

Comments

@tjmehta
Copy link
Owner

tjmehta commented Jul 1, 2015

to get unique values in an array

  1. make it work with arr.reduce
  2. maybe accept an an optional equals arg?
@bkendall
Copy link
Collaborator

bkendall commented Jul 1, 2015

thoughts:

  • wouldn’t this be very similar (functionally) to a set?
  • I know we probably don’t want to add a entire new data type, but if something like that already exists, don’t need to re-make
  • unique would be a good name. alias to deduplicate/dedupe?
  • also like that it would take a function: becomes an awesome Array.filter

@tjmehta
Copy link
Owner Author

tjmehta commented Jul 1, 2015

Nice we should make it work with Array.prototype.filter versus Array.prototype.reduce


@tjmehta

On Wed, Jul 1, 2015 at 2:28 PM, Bryan Kendall notifications@github.com
wrote:

thoughts:

  • wouldn’t this be very similar (functionally) to a set?
  • I know we probably don’t want to add a entire new data type, but if something like that already exists, don’t need to re-make
  • unique would be a good name. alias to deduplicate/dedupe?

- also like that it would take a function: becomes an awesome Array.filter

Reply to this email directly or view it on GitHub:
#103 (comment)

@tjmehta tjmehta changed the title add unique unique Dec 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants