Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix queryverse integration #64

Merged
merged 2 commits into from
Jan 9, 2020
Merged

Conversation

davidanthoff
Copy link
Contributor

#63 broke the queryverse integration. This fixes it :)

The two new dependencies are already a dependency of Tables.jl, so this effectively does not add any new deps.

@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #64 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage    93.1%   93.12%   +0.01%     
==========================================
  Files           9        9              
  Lines         783      785       +2     
==========================================
+ Hits          729      731       +2     
  Misses         54       54
Impacted Files Coverage Δ
src/SASLib.jl 92.01% <ø> (ø) ⬆️
src/tables.jl 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae65b23...3162b28. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 93.271% when pulling 3162b28 on davidanthoff:queryverse into ae65b23 on tk3369:master.

@tk3369
Copy link
Owner

tk3369 commented Jan 9, 2020

@davidanthoff Thanks very much for the contribution. I have never tested with Queryverse before. Perhaps I will check that out again. BTW, you just hit a jackpot:

Test Summary: | Pass  Total
SASLib        |  222    222
   Testing SASLib tests passed 
Build success

@tk3369 tk3369 merged commit 5098b8f into tk3369:master Jan 9, 2020
@davidanthoff davidanthoff deleted the queryverse branch January 14, 2020 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants