Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleaning up reader #141

Merged
merged 8 commits into from
Jun 15, 2023
Merged

refactor: cleaning up reader #141

merged 8 commits into from
Jun 15, 2023

Conversation

tlambert03
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #141 (31ebdaa) into main (0d1242b) will increase coverage by 0.92%.
The diff coverage is 98.38%.

❗ Current head 31ebdaa differs from pull request most recent head 77d67da. Consider uploading reports for the commit 77d67da to get more accurate results

@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   91.43%   92.35%   +0.92%     
==========================================
  Files          14       14              
  Lines        1949     1897      -52     
==========================================
- Hits         1782     1752      -30     
+ Misses        167      145      -22     
Impacted Files Coverage Δ
src/nd2/_pysdk/_sdk_types.py 100.00% <ø> (ø)
src/nd2/_pysdk/_pysdk.py 89.71% <96.87%> (-1.34%) ⬇️
src/nd2/_binary.py 85.56% <100.00%> (+0.15%) ⬆️
src/nd2/_clx_xml.py 93.18% <100.00%> (+0.87%) ⬆️
src/nd2/_legacy/_legacy.py 89.90% <100.00%> (ø)
src/nd2/_pysdk/_parse.py 94.24% <100.00%> (ø)
src/nd2/nd2file.py 95.13% <100.00%> (+6.07%) ⬆️
src/nd2/structures.py 96.06% <100.00%> (+2.78%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tlambert03 tlambert03 merged commit 9b91e1f into main Jun 15, 2023
@tlambert03 tlambert03 deleted the cleanup branch June 15, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant