Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: big update to events parsing. add .events method, deprecate recorded_date #144

Merged
merged 12 commits into from
Jun 24, 2023

Conversation

tlambert03
Copy link
Owner

@tlambert03 tlambert03 commented Jun 21, 2023

This PR adds proper support for parsing events that occur during the course of an experiment.

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #144 (c58d0bd) into main (74faef9) will increase coverage by 0.16%.
The diff coverage is 92.78%.

@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   92.64%   92.80%   +0.16%     
==========================================
  Files          14       14              
  Lines        1890     2058     +168     
==========================================
+ Hits         1751     1910     +159     
- Misses        139      148       +9     
Impacted Files Coverage Δ
src/nd2/_legacy/_legacy.py 88.63% <20.00%> (-1.28%) ⬇️
src/nd2/_clx_xml.py 89.36% <50.00%> (-3.83%) ⬇️
src/nd2/_pysdk/_parse.py 92.92% <77.77%> (-1.66%) ⬇️
src/nd2/_pysdk/_pysdk.py 91.30% <96.96%> (+1.59%) ⬆️
src/nd2/_pysdk/_sdk_types.py 100.00% <100.00%> (ø)
src/nd2/_util.py 90.62% <100.00%> (+3.66%) ⬆️
src/nd2/nd2file.py 95.42% <100.00%> (+0.28%) ⬆️
src/nd2/structures.py 96.24% <100.00%> (+0.18%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tlambert03 tlambert03 changed the title feat: parse events into proper structure feat: big update to events parsing. add .events method, deprecate recorded_date Jun 24, 2023
@tlambert03 tlambert03 merged commit c5c4a5b into main Jun 24, 2023
@tlambert03 tlambert03 deleted the events branch June 24, 2023 22:27
@tlambert03 tlambert03 added the enhancement New feature or request label Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant