Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix frame_metadata and various metadata typing #155

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Conversation

tlambert03
Copy link
Owner

there was a bug in ND2File.frame_metadata

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #155 (229fb29) into main (52e5e01) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
+ Coverage   93.18%   93.28%   +0.10%     
==========================================
  Files          15       15              
  Lines        2229     2220       -9     
==========================================
- Hits         2077     2071       -6     
+ Misses        152      149       -3     
Impacted Files Coverage Δ
src/nd2/_pysdk/_sdk_types.py 100.00% <ø> (ø)
src/nd2/_pysdk/_parse.py 93.48% <100.00%> (+0.49%) ⬆️
src/nd2/_pysdk/_pysdk.py 91.44% <100.00%> (+0.37%) ⬆️
src/nd2/structures.py 96.07% <100.00%> (-0.03%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 4, 2023

CodSpeed Performance Report

Merging #155 will degrade performances by 53.41%

Comparing fix-frame-meta (229fb29) with main (52e5e01)

🎉 Hooray! pytest-codspeed just leveled up to 2.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

❌ 1 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix-frame-meta Change
test_time_imread_dask[jonas_control002] 1.6 s 3.5 s -53.41%

@tlambert03 tlambert03 merged commit c0f1c78 into main Jul 4, 2023
17 of 18 checks passed
@tlambert03 tlambert03 deleted the fix-frame-meta branch July 4, 2023 15:43
@tlambert03 tlambert03 added the bug Something isn't working label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant