Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: decode compressed lite variant, and read string type tags #159

Merged
merged 3 commits into from
Jul 8, 2023

Conversation

tlambert03
Copy link
Owner

@tlambert03 tlambert03 commented Jul 8, 2023

This PR parses and includes string columns found in the CustomData chunks (which were previously skipped, lacking good examples).

It also now deflates and parses compressed lite variant data chunks

@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Merging #159 (208e1aa) into main (34a2586) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
+ Coverage   93.49%   93.66%   +0.16%     
==========================================
  Files          16       16              
  Lines        2261     2272      +11     
==========================================
+ Hits         2114     2128      +14     
+ Misses        147      144       -3     
Impacted Files Coverage Δ
src/nd2/_binary.py 91.01% <100.00%> (ø)
src/nd2/_clx_lite.py 91.50% <100.00%> (+1.41%) ⬆️
src/nd2/_pysdk/_pysdk.py 92.70% <100.00%> (+0.90%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 8, 2023

CodSpeed Performance Report

Merging #159 will not alter performances

Comparing string-events (208e1aa) with main (34a2586)

Summary

✅ 13 untouched benchmarks

@tlambert03 tlambert03 merged commit a86bb6d into main Jul 8, 2023
18 checks passed
@tlambert03 tlambert03 deleted the string-events branch July 8, 2023 20:48
@tlambert03 tlambert03 added the enhancement New feature or request label Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant